From 2ab032b8718d6dcfbe0904eb5d8ad2cb6c4d2889 Mon Sep 17 00:00:00 2001 From: Jkorf Date: Tue, 7 Dec 2021 15:47:14 +0100 Subject: [PATCH] Updated version --- CryptoExchange.Net/Clients/BaseSocketClient.cs | 4 +++- CryptoExchange.Net/Converters/DateTimeConverter.cs | 5 +++++ CryptoExchange.Net/CryptoExchange.Net.csproj | 8 ++++---- README.md | 3 +++ 4 files changed, 15 insertions(+), 5 deletions(-) diff --git a/CryptoExchange.Net/Clients/BaseSocketClient.cs b/CryptoExchange.Net/Clients/BaseSocketClient.cs index fd24d3b..0d6317b 100644 --- a/CryptoExchange.Net/Clients/BaseSocketClient.cs +++ b/CryptoExchange.Net/Clients/BaseSocketClient.cs @@ -390,6 +390,7 @@ namespace CryptoExchange.Net /// Needs to check if a received message matches a handler by request. After subscribing data message will come in. These data messages need to be matched to a specific connection /// to pass the correct data to the correct handler. The implementation of this method should check if the message received matches the subscribe request that was sent. /// + /// The socket connection the message was recieved on /// The received data /// The subscription request /// True if the message is for the subscription which sent the request @@ -398,6 +399,7 @@ namespace CryptoExchange.Net /// Needs to check if a received message matches a handler by identifier. Generally used by GenericHandlers. For example; a generic handler is registered which handles ping messages /// from the server. This method should check if the message received is a ping message and the identifer is the identifier of the GenericHandler /// + /// The socket connection the message was recieved on /// The received data /// The string identifier of the handler /// True if the message is for the handler which has the identifier @@ -468,7 +470,7 @@ namespace CryptoExchange.Net /// Adds a generic message handler. Used for example to reply to ping requests /// /// The name of the request handler. Needs to be unique - /// The action to execute when receiving a message for this handler (checked by ) + /// The action to execute when receiving a message for this handler (checked by ) protected void AddGenericHandler(string identifier, Action action) { genericHandlers.Add(identifier, action); diff --git a/CryptoExchange.Net/Converters/DateTimeConverter.cs b/CryptoExchange.Net/Converters/DateTimeConverter.cs index 1a0d27b..79714ab 100644 --- a/CryptoExchange.Net/Converters/DateTimeConverter.cs +++ b/CryptoExchange.Net/Converters/DateTimeConverter.cs @@ -1,6 +1,7 @@ using Newtonsoft.Json; using System; using System.Diagnostics; +using System.Diagnostics.CodeAnalysis; using System.Globalization; namespace CryptoExchange.Net.Converters @@ -150,24 +151,28 @@ namespace CryptoExchange.Net.Converters /// /// /// + [return: NotNullIfNotNull("time")] public static long? ConvertToSeconds(DateTime? time) => time == null ? null: (long)Math.Round((time.Value - _epoch).TotalSeconds); /// /// Convert a DateTime value to milliseconds since epoch (01-01-1970) value /// /// /// + [return: NotNullIfNotNull("time")] public static long? ConvertToMilliseconds(DateTime? time) => time == null ? null : (long)Math.Round((time.Value - _epoch).TotalMilliseconds); /// /// Convert a DateTime value to microseconds since epoch (01-01-1970) value /// /// /// + [return: NotNullIfNotNull("time")] public static long? ConvertToMicroseconds(DateTime? time) => time == null ? null : (long)Math.Round((time.Value - _epoch).Ticks / ticksPerMicrosecond); /// /// Convert a DateTime value to nanoseconds since epoch (01-01-1970) value /// /// /// + [return: NotNullIfNotNull("time")] public static long? ConvertToNanoseconds(DateTime? time) => time == null ? null : (long)Math.Round((time.Value - _epoch).Ticks / ticksPerNanosecond); diff --git a/CryptoExchange.Net/CryptoExchange.Net.csproj b/CryptoExchange.Net/CryptoExchange.Net.csproj index 19683d7..a587352 100644 --- a/CryptoExchange.Net/CryptoExchange.Net.csproj +++ b/CryptoExchange.Net/CryptoExchange.Net.csproj @@ -1,4 +1,4 @@ - + netstandard2.0;netstandard2.1 @@ -6,16 +6,16 @@ CryptoExchange.Net JKorf A base package for implementing cryptocurrency exchange API's - 5.0.0 + 5.0.0-alpha1 5.0.0 - 5.0.0 + 5.0.0-alpha1 false git https://github.com/JKorf/CryptoExchange.Net.git https://github.com/JKorf/CryptoExchange.Net en true - 5.0.0 + 5.0.0.1-alpha - New client structures, multiple improvements and changes. Details will be available later enable 9.0 MIT diff --git a/README.md b/README.md index 124aaeb..70ae96f 100644 --- a/README.md +++ b/README.md @@ -326,6 +326,9 @@ private void SomeMethod() ```` ## Release notes +* Version 5.0.0.1-alpha - 07 Dec 2021 + * New client structures, multiple improvements and changes. Details will be available later + * Version 4.2.8 - 08 Oct 2021 * Fixed deadlock in socket receive * Fixed issue in reconnection handling when the client is disconnected again during resubscribing