From 07d0a0159d850b973afb3886d9eae698bd9ff2ad Mon Sep 17 00:00:00 2001
From: Ben Davison <BDA@simcorp.com>
Date: Thu, 30 Jan 2020 22:01:14 +0000
Subject: [PATCH] Use ValueTuple for BestOffers

---
 CryptoExchange.Net.UnitTests/SymbolOrderBookTests.cs | 12 ++++++------
 CryptoExchange.Net/Interfaces/ISymbolOrderBook.cs    |  2 +-
 CryptoExchange.Net/OrderBook/SymbolOrderBook.cs      |  6 ++----
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/CryptoExchange.Net.UnitTests/SymbolOrderBookTests.cs b/CryptoExchange.Net.UnitTests/SymbolOrderBookTests.cs
index d0ac5c6..4f1214f 100644
--- a/CryptoExchange.Net.UnitTests/SymbolOrderBookTests.cs
+++ b/CryptoExchange.Net.UnitTests/SymbolOrderBookTests.cs
@@ -58,12 +58,12 @@ namespace CryptoExchange.Net.UnitTests
         {
             var symbolOrderBook = new TestableSymbolOrderBook();
             Assert.IsNotNull(symbolOrderBook.BestOffers);
-            Assert.IsNotNull(symbolOrderBook.BestOffers.Item1);
-            Assert.IsNotNull(symbolOrderBook.BestOffers.Item2);
-            Assert.AreEqual(0m, symbolOrderBook.BestOffers.Item1.Price);
-            Assert.AreEqual(0m, symbolOrderBook.BestOffers.Item1.Quantity);
-            Assert.AreEqual(0m, symbolOrderBook.BestOffers.Item2.Price);
-            Assert.AreEqual(0m, symbolOrderBook.BestOffers.Item2.Quantity);
+            Assert.IsNotNull(symbolOrderBook.BestOffers.BestBid);
+            Assert.IsNotNull(symbolOrderBook.BestOffers.BestAsk);
+            Assert.AreEqual(0m, symbolOrderBook.BestOffers.BestBid.Price);
+            Assert.AreEqual(0m, symbolOrderBook.BestOffers.BestBid.Quantity);
+            Assert.AreEqual(0m, symbolOrderBook.BestOffers.BestAsk.Price);
+            Assert.AreEqual(0m, symbolOrderBook.BestOffers.BestAsk.Quantity);
         }
     }
 }
diff --git a/CryptoExchange.Net/Interfaces/ISymbolOrderBook.cs b/CryptoExchange.Net/Interfaces/ISymbolOrderBook.cs
index 10275c3..06321d8 100644
--- a/CryptoExchange.Net/Interfaces/ISymbolOrderBook.cs
+++ b/CryptoExchange.Net/Interfaces/ISymbolOrderBook.cs
@@ -73,7 +73,7 @@ namespace CryptoExchange.Net.Interfaces
         /// <summary>
         /// BestBid/BesAsk returned as a pair
         /// </summary>
-        Tuple<ISymbolOrderBookEntry, ISymbolOrderBookEntry> BestOffers { get; }
+        (ISymbolOrderBookEntry BestBid, ISymbolOrderBookEntry BestAsk) BestOffers { get; }
 
         /// <summary>
         /// Start connecting and synchronizing the order book
diff --git a/CryptoExchange.Net/OrderBook/SymbolOrderBook.cs b/CryptoExchange.Net/OrderBook/SymbolOrderBook.cs
index 73bd76f..143307b 100644
--- a/CryptoExchange.Net/OrderBook/SymbolOrderBook.cs
+++ b/CryptoExchange.Net/OrderBook/SymbolOrderBook.cs
@@ -162,12 +162,10 @@ namespace CryptoExchange.Net.OrderBook
         /// <summary>
         /// BestBid/BesAsk returned as a pair
         /// </summary>
-        public Tuple<ISymbolOrderBookEntry, ISymbolOrderBookEntry>  BestOffers {
+        public (ISymbolOrderBookEntry BestBid, ISymbolOrderBookEntry BestAsk) BestOffers {
             get {
                 lock (bookLock)
-                {
-                    return new Tuple<ISymbolOrderBookEntry, ISymbolOrderBookEntry>(BestBid,BestAsk);
-                }
+                    return (BestBid,BestAsk);
             }
         }