From 00456ea6d2c65cb1260108aa7cdc572a941e39a5 Mon Sep 17 00:00:00 2001
From: JKorf <jankorf91@gmail.com>
Date: Thu, 16 Aug 2018 08:24:54 +0200
Subject: [PATCH] Added locking of SecureString, wasn't thread safe

---
 CryptoExchange.Net/ExtensionMethods.cs | 37 ++++++++++++++------------
 1 file changed, 20 insertions(+), 17 deletions(-)

diff --git a/CryptoExchange.Net/ExtensionMethods.cs b/CryptoExchange.Net/ExtensionMethods.cs
index f3fc934..6756b03 100644
--- a/CryptoExchange.Net/ExtensionMethods.cs
+++ b/CryptoExchange.Net/ExtensionMethods.cs
@@ -31,27 +31,30 @@ namespace CryptoExchange.Net
 
         public static string GetString(this SecureString source)
         {
-            string result = null;
-            int length = source.Length;
-            IntPtr pointer = IntPtr.Zero;
-            char[] chars = new char[length];
-
-            try
+            lock (source)
             {
-                pointer = Marshal.SecureStringToBSTR(source);
-                Marshal.Copy(pointer, chars, 0, length);
+                string result = null;
+                int length = source.Length;
+                IntPtr pointer = IntPtr.Zero;
+                char[] chars = new char[length];
 
-                result = string.Join("", chars);
-            }
-            finally
-            {
-                if (pointer != IntPtr.Zero)
+                try
                 {
-                    Marshal.ZeroFreeBSTR(pointer);
-                }
-            }
+                    pointer = Marshal.SecureStringToBSTR(source);
+                    Marshal.Copy(pointer, chars, 0, length);
 
-            return result;
+                    result = string.Join("", chars);
+                }
+                finally
+                {
+                    if (pointer != IntPtr.Zero)
+                    {
+                        Marshal.ZeroFreeBSTR(pointer);
+                    }
+                }
+
+                return result;
+            }
         }
     }
 }